feat(rabbitmq): Add wait handlers for v2 package#7949
Open
SerseusWasTaken wants to merge 3 commits into
Open
Conversation
Relates to STACKITSDK-465
marceljk
reviewed
Jun 19, 2026
feat(rabbitmq): expand rabbitmq example with wait and cleanup instance
SerseusWasTaken
force-pushed
the
feat/rabbitmq/wait-handlers-v2
branch
from
ee12d18 to
01646b4
Compare
marceljk
reviewed
Jun 19, 2026
| region := "eu01" | ||
| planId := "PLAN_ID" | ||
|
|
||
| // Create a new API client, that uses default authentication and configuration |
Contributor
There was a problem hiding this comment.
Can't comment the correct line, but with the change from v1 to v2, the configuration of the client should be without the region, because they will be configured on endpoint level.
Can you remove config.WithRegion("eu01") of the client configuration?
Comment on lines
30
to
31
| fmt.Fprintf(os.Stderr, "Error when calling `GetInstances`: %v\n", err) | ||
| } else { |
Contributor
There was a problem hiding this comment.
can you add an os.Exit(1) in the error case?
Comment on lines
38
to
39
| fmt.Fprintf(os.Stderr, "Error when calling `GetOfferings`: %v\n", err) | ||
| } else { |
Comment on lines
51
to
52
| fmt.Fprintf(os.Stderr, "Error when calling `CreateInstance`: %v\n", err) | ||
| } else { |
Contributor
There was a problem hiding this comment.
and here. otherwise it will fail in the call of waithandler with a nil pointer exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to STACKITSDK-465
Description
relates to #STACKITSDK-465
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)